-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand functionality: limit group for adapter #41
base: master
Are you sure you want to change the base?
Expand functionality: limit group for adapter #41
Conversation
Hi, @Envek. I done actualize and fixed failing specs. Running specs randomly is was a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request and sorry for the late reply. I will try to get to this in a few days.
spec/spec_helper.rb
Outdated
@@ -12,8 +12,6 @@ | |||
# Disable RSpec exposing methods globally on `Module` and `main` | |||
config.disable_monkey_patching! | |||
|
|||
config.order = :random |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not good when test suite result depends on order in which tests are executed. These dependencies need to be detected and removed (maybe something need to be added to the Yabeda.reset!
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it just solved my problem. Reverted it.
Hey, @Envek. In continue my PR. I want to extend the metrics limit functionality for the adapter.
But specs do randomly green or red. For example:
What do you think about this? Thanks.