Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand functionality: limit group for adapter #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

killondark
Copy link

Hey, @Envek. In continue my PR. I want to extend the metrics limit functionality for the adapter.

# current version:
Yabeda.configure do
  group :mushrooms do
    adapter :basket_adapter
    counter :champignon_counter
  end
end

# added version:
Yabeda.configure do
  group :mushrooms do
    counter :champignon_counter
  end

  adapter :basket_adapter do
    include_group :mushrooms
  end
end

But specs do randomly green or red. For example:

1) Yabeda::Counter when config has no group execute perform_counter_increment!
   Failure/Error: let(:counter) { Yabeda.test_counter }
   
   NoMethodError:
     undefined method `test_counter' for Yabeda:Module
   # ./spec/yabeda/counter_spec.rb:14:in `block (3 levels) in <top (required)>'
   # ./spec/yabeda/counter_spec.rb:4:in `block (2 levels) in <top (required)>'
   # ./spec/yabeda/counter_spec.rb:30:in `block (3 levels) in <top (required)>'

What do you think about this? Thanks.

@killondark
Copy link
Author

Hi, @Envek. I done actualize and fixed failing specs. Running specs randomly is was a problem.

Copy link
Member

@Envek Envek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request and sorry for the late reply. I will try to get to this in a few days.

@@ -12,8 +12,6 @@
# Disable RSpec exposing methods globally on `Module` and `main`
config.disable_monkey_patching!

config.order = :random
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not good when test suite result depends on order in which tests are executed. These dependencies need to be detected and removed (maybe something need to be added to the Yabeda.reset!)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it just solved my problem. Reverted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants