Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset job failed flag #3

Merged
merged 5 commits into from
Apr 5, 2024
Merged

reset job failed flag #3

merged 5 commits into from
Apr 5, 2024

Conversation

Arlantir
Copy link
Contributor

@Arlantir Arlantir commented Apr 5, 2024 •
edited
Loading

  • Fixed an error: if the job failed, the flag job.opts[:failed] was not reset, and metrics for the failed job continued to be sent.
  • Fixed the test functionality.
  • Refactored the tests.

fix #2

@Arlantir Arlantir changed the title reset job failed flag #2 fix reset job failed flag #2 Apr 5, 2024
@Arlantir Arlantir changed the title fix reset job failed flag #2 reset job failed flag Apr 5, 2024
Envek
Envek reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@Envek Envek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! Here are some minor suggestions (see individual comments below)

.gitignore Outdated Show resolved Hide resolved
lib/yabeda/schked.rb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Envek Envek merged commit afce7c8 into yabeda-rb:master Apr 5, 2024
@Envek
Copy link
Member

Envek commented Apr 5, 2024

Thank you very much! Released in 0.2.1, enjoy!

@Arlantir
Copy link
Contributor Author

Arlantir commented Apr 5, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bibendi bibendi bibendi left review comments

@Envek Envek Envek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reset job failed flag
3 participants
@Arlantir @Envek @bibendi