avoid stack overflow from power_on calling hard_reset #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diekleinekuh
force-pushed
the
fix_stack_overflow
branch
from
aad7aa0 to
95f1676
Compare
maximeborges
approved these changes
Oct 4, 2023
diekleinekuh
force-pushed
the
fix_stack_overflow
branch
from
95f1676 to
2151055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
power_on was calling hard_reset which called power_on again. This caused the stack overflow we saw for the last months.
I removed the call to power_on from hard_reset and also removed the reset_calls from power_on. Instead I placed those calls explicitely where needed.
I tested this on Niro100 and it still seems to connect as it did before. So it think it will not make things any worse.