feat: sample builders #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorchakov
force-pushed
the
feat/sample-builders
branch
from
d7ae97a to
dc93ce6
Compare
sandhawalia
reviewed
Nov 20, 2024
sandhawalia
reviewed
Nov 20, 2024
sandhawalia
reviewed
Nov 20, 2024
sandhawalia
approved these changes
Nov 20, 2024
egorchakov
force-pushed
the
feat/sample-builders
branch
from
dc93ce6 to
6a03e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces sample builders based on
polars.DataFrame.rollingandpolars.DataFrame.group_by_dynamicoperating on int/time columns.NOTE: resulting samples may not be of the same length due to windowing -- though that can be enforced through a
array_length(...) == Nfilter clause (seeconfig/_templates/dataset/yaak.yaml)