Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hdf5 support #14

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat: add hdf5 support #14

merged 1 commit into from
Oct 11, 2024

Conversation

egorchakov
Copy link
Contributor

This PR adds hdf5 frame/table readers and an example for Table Setup from Dishwasher.

image

NOTE: Unfortunately, polars doesn't natively support hdf5 (pola-rs/polars#3520), and pandas/vaex didn't work either for the example dataset -- hence the raw iteration.

@egorchakov egorchakov requested a review from sandhawalia October 9, 2024 15:54
@sandhawalia
Copy link
Contributor

LGTM. As we are now upto 4 dataset formats. Shall we add some supporting docs f.e HOWTO.md

@egorchakov
Copy link
Contributor Author

Shall we add some supporting docs f.e HOWTO.md

lets tee it up for the next release

@egorchakov egorchakov merged commit aed93a1 into main Oct 11, 2024
1 check passed
@egorchakov egorchakov deleted the feat/hdf5 branch October 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandhawalia sandhawalia sandhawalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorchakov @sandhawalia