feat: add VALI-based (GPU) video reader #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we update yaak dataset config and verify if the seek issue persists ? |
|
We can't actually use it on our videos since they're all VFR. I tried converting one to CFR, and the seek issue was definitely there. Took me a while to trace it back though. |
sandhawalia
approved these changes
Oct 2, 2024
egorchakov
force-pushed
the
feat/gpu-video-reader
branch
from
11d2cae to
8a1d8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with one of VALI's own files: https://github.com/RomanArzumanyan/VALI/blob/main/tests/data/test.mp4
NOTE: seeking seems problematic (RomanArzumanyan/VALI#111), might need to hold off on merging