Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pattern position (#212) #223

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielBretzigheimer
Copy link

@DanielBretzigheimer DanielBretzigheimer commented Aug 11, 2022

I have (hopefully) resolved the problem of the pattern not starting at the right position. The other issues. I tried fixing the other two issues mentioned by me here, but haven't found a solution yet.

Maybe someone else has an idea or a hint :)

@DanielBretzigheimer DanielBretzigheimer force-pushed the feature/svg_pattern_fixed_#212 branch 2 times, most recently from b2e2a3b to 9e9d4d5 Compare August 12, 2022 18:52
@DanielBretzigheimer
Copy link
Author

I've added a test case for the pattern offset fix

@DanielBretzigheimer DanielBretzigheimer marked this pull request as ready for review August 12, 2022 18:55
@DanielBretzigheimer
Copy link
Author

Fixed second point of my comment.

@HackbrettXXX
Copy link
Member

Could part of the issue be similar to parallax/jsPDF#3627? Or the respective svg2pdf issue #244? If that's the case then I think we should fix the unit-scaling-related part on jsPDF side.

@HackbrettXXX HackbrettXXX marked this pull request as draft December 11, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants