Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21115: @breadcrumb-color doesn't apply to links in the Breadcrumb #3536

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Oct 3, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21115

Changes

Description

  • Updated the color used by the links in the breadcrumb bar.

Screenshots & Video

Here, I set the color @breadcrumb-color to a lightgreen in order to be able to see it easily.
Before the changes proposed in this PR:
Screenshot from 2024-10-03 16-53-56
After the changes proposed in this PR (also changed the @breadcrumb-active-color to a dark green to make sure it still works well together):
Screenshot from 2024-10-03 17-00-52

Executed Tests

Manual tests, see above. This is a style change only, and it doesn't change the UI layout, so it should be pretty safe for automated tests.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.X
    • 16.4.X

@Sereza7 Sereza7 added backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x labels Oct 3, 2024
@michitux
Copy link
Contributor

Technically, this looks good. However, looking at this pull request and the issue again I wonder if there is an agreement that these colors should actually be applied to the links. I think it would be good to have small proposal to agree about this. The issue also mentions introducing new color variables for the links as an alternative from what I understand.

@Sereza7
Copy link
Contributor Author

Sereza7 commented Oct 16, 2024

Started https://forum.xwiki.org/t/breadcrumb-links-color/15735 👍
Thanks for your review!

@Sereza7
Copy link
Contributor Author

Sereza7 commented Oct 16, 2024

Setting it as a draft:

If option 1. is picked (the one currently implemented), make sure to correct the looks of this solution with the default Iceberg,

@Sereza7 Sereza7 marked this pull request as draft October 16, 2024 09:41
@Sereza7 Sereza7 removed the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label Oct 31, 2024
* Created a breadcrumb-link-color variable in the colorTheme
* Updated the existing colorTheme pages to use this new property for the link.

Note: I doubt this is really needed for the change to work, but it makes things more consistent and easier to understand.
@Sereza7
Copy link
Contributor Author

Sereza7 commented Nov 6, 2024

Option 2 was picked. I updated the PR to implement the second option with a new Flamingo ColorTheme variable. After a self review, I'll post the updated status and reopen this PR for review :)

@Sereza7
Copy link
Contributor Author

Sereza7 commented Nov 6, 2024

In the current state of the PR, here is what changing the value of the colorTheme variable to pink amounts to:
image

When hovered, the links take the same color as the other elements (same behavior as before applying the changes from this PR). We did not introduce a @breadcrumb-link-active-color so we're still using @breadcrumb-active-color.

Here's what the UI to update this value looks like in Iceberg:
image


By default, this variable takes the same value as @link-color, which results in the same UI as what was obtained before. This value is overriden if the user explicitely sets the value in the active colorTheme (or sets it in a SSX).
image

@Sereza7 Sereza7 marked this pull request as ready for review November 6, 2024 14:05
@michitux michitux merged commit 35425fd into xwiki:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants