Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22458: Message boxes variant style does not match initial design #3527

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Sep 30, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22458

Changes

Description

  • Updated style to get back the margin next to the icon on inline blocks.
  • Updated style of standalone boxes to both:
    • fit the design agreed upon earlier
    • avoid style regression on old hard-coded boxes

Clarifications

  • See comments in the code

Screenshots & Video

The style changes on inline messages are quick easy to test. However making sure that we did not break backward compatibility while making the new design was a bit more complicated. The first example shows various uses of the updated macro. The second and third example display some hard coded boxes that we can find in the UI: the second one contains a specific HTML content that did not work well with the style changes (one of the reasons to make the selector for new styles specific) -- the third one contains a hard coded icon.
Before the PR:
22458-beforePR1
22458-beforePR2
22458-beforePR3
after the PR:
22458-afterPR1
22458-afterPR2
22458-afterPR3

Executed Tests

Manual tests only, this is a style change.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None, same as changes for XWIKI-21452 brought in 16.7.0+

* Updated style to get back the margin next to the icon on inline blocks.
@surli surli merged commit a353859 into xwiki:master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants