[Misc] Fix repository clone error on NTFS filesystems #3524
Conversation
surli
added
backport stable-15.10.x
|
|
||
| // We shouldn't store files with special characters in the repository, since some filesystems don't support it. | ||
| // Instead, we create the file during the test. | ||
| Path unescapedFile = Files.createTempFile("<strong>", null); |
There was a problem hiding this comment.
Isn't this going to fail during the test (because it won't be able to create a file named like this) on Windows ?
There was a problem hiding this comment.
Not much we can do about that, since this test is specifically about testing this kind of filename no? At least the PR fixes the current situation preventing to perform the clone.
There was a problem hiding this comment.
Not much we can do about that, since this test is specifically about testing this kind of filename no?
If the test is only about display, we can simply upload the attachment using something that let us choose the name of the attachment without the need to have an actual file on the filesystem (like REST).
There was a problem hiding this comment.
This test is about testing the actual JavaScript code for handling the upload. See XWIKI-19611 for context.
There was a problem hiding this comment.
That's a good question. I would expect the nio.Files API to support such use cases and escape the name on NTFS filesystems, but I can't test it.
Having the name escaped would definitely make the test useless though. Do we support running Docker tests on Windows?
There was a problem hiding this comment.
Do we support running Docker tests on Windows?
yes, in theory we should be able to build and test xwiki in any system
There was a problem hiding this comment.
This test is about testing the actual JavaScript code for handling the upload.
OK, so that's indeed more complex. Maybe there would be some hack to have the browser end up with a different name than the actual file on filesystem...
There was a problem hiding this comment.
We didn't at the time since TC was not supporting it (it was very experimental), but I haven't retested it, maybe it works now: https://java.testcontainers.org/supported_docker_environment/windows/
Requires a windows machine AFAICS.
Changes
Description
<strong>EscapedAttachment.txtis no longer stored on the repository. Instead, a file containing the<strong>tag is created during the test that requires it.Clarifications
This change requires adding to the page object an upload method supporting local files, which is done through Selenium's LocalFileDetector.
Executed Tests
AttachmentITwas run locally with the included changes.Expected merging strategy