XWIKI-22335: Cannot import a ppt with LibreOffice 24.2.5

[michitux]

Jira URL

https://jira.xwiki.org/browse/XWIKI-22335

Changes

Description

• Convert to PDF and extract images from the PDF
• Adapt the unit test
• Add new configuration options to configure format and quality

Still open:

• Add a unit test for the configuration loader, verifying in particular that the fallback is correctly working.
• Check the names of the new configuration options and add them to the configuration file template.

Clarifications

• LibreOffice dropped support for direct export to images
• Exporting to PDF and then converting the PDF to images using the existing dependency PDFBox dependency seems like the most backwards-compatible

Screenshots & Video

No UI changes.

Executed Tests

LANG=C.UTF-8 mvn clean install -Pdocker,legacy,integration-tests,snapshotModules,distribution,flavor-integration-tests -pl $(git diff --name-only --merge-base origin/master | awk -F'/' '{for(i=NF-1; i>0; i--){if($i ~ /src$/){printf(":%s\n", $(i-1)); break;}}}' | sort -u | paste -sd "," -),:xwiki-platform-office-test-docker

Note: The test coverage is currently too low as the code for the configuration loading still needs a unit test.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • stable-16.4.x
  • stable-15.10.x

[tmortagne]

Seems the comment is not accurate anymore.

[surli]

It is accurate, the full comment is:

Note: we use https://download.documentfoundation.org/libreoffice/stable/ and not https://downloadarchive.documentfoundation.org/libreoffice/old so that we can benefit [...]

You might have missed the beginning on the line above.

[tmortagne]

OK, it was not accurate before :)

[surli]

Yep I didn't change the comment when I changed it to use 7.6 with the old url.

[github-actions]

The backport to stable-15.10.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable-15.10.x stable-15.10.x
# Navigate to the new working tree
cd .worktrees/backport-stable-15.10.x
# Create a new branch
git switch --create backport-3517-to-stable-15.10.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 acd6ed3f38a03ee66b721e56093decb3cec1b4b6
# Push it to GitHub
git push --set-upstream origin backport-3517-to-stable-15.10.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable-15.10.x

Then, create a pull request where the base branch is stable-15.10.x and the compare/head branch is backport-3517-to-stable-15.10.x.

[github-actions]

The backport to stable-16.4.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable-16.4.x stable-16.4.x
# Navigate to the new working tree
cd .worktrees/backport-stable-16.4.x
# Create a new branch
git switch --create backport-3517-to-stable-16.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 acd6ed3f38a03ee66b721e56093decb3cec1b4b6
# Push it to GitHub
git push --set-upstream origin backport-3517-to-stable-16.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable-16.4.x

Then, create a pull request where the base branch is stable-16.4.x and the compare/head branch is backport-3517-to-stable-16.4.x.