Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-21849: No link to next page at the bottom of LiveData #2837

Merged
merged 1 commit into from
Feb 2, 2024
Merged

XWIKI-21849: No link to next page at the bottom of LiveData #2837

merged 1 commit into from
Feb 2, 2024

Conversation

manuelleduc
Copy link
Contributor

@manuelleduc manuelleduc commented Feb 1, 2024 •
edited
Loading

Jira URL

https://jira.xwiki.org/browse/XWIKI-21849

Changes

Description

  • Introduce the pagination at the bottom of the table and cards layouts

Clarifications

  • Add a LivedataPagination in the LivedataBottombar of LayoutCards and LayoutTable.

Screenshots & Video

Empty LD

Before

image

After

image

LD With Content

Before

image

After

image

Executed Tests

mvn clean install \
  -Pquality,integration-tests,docker \
  -pl :xwiki-platform-livedata-webjar -amd -f xwiki-platform-core/xwiki-platform-livedata

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • stable-14.10.x
    • stable-15.5.x
    • stable-15.10.x

@manuelleduc manuelleduc added the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label Feb 1, 2024
@manuelleduc manuelleduc merged commit cf7cd6c into xwiki:master Feb 2, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@manuelleduc @github-actions
XWIKI-21849: No link to next page at the bottom of LiveData (#2837)
33dbce0 
(cherry picked from commit cf7cd6c)
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
manuelleduc added a commit that referenced this pull request Feb 2, 2024
@github-actions @manuelleduc
XWIKI-21849: No link to next page at the bottom of LiveData (#2837) (#…
1eee209 
…2838)

(cherry picked from commit cf7cd6c)

Co-authored-by: Manuel Leduc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manuelleduc