XWIKI-14342: Make Extension Manager use IconThemes #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the Hardcoded silk icons from the CSS * Fixed style to fit actual icon nodes in the same place as they used to be as background. * Added them in the velocity template instead * Fixed the behavior of status switch when loading dependencies.
Sereza7
added
the
backport stable-15.10.x
Sereza7
removed
the
backport stable-15.10.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-14342
Changes
Description
Clarifications
Screenshots & Video
Here is a demo of the changes brought in this PR. In the first part, we can see that the looks with the silk iconTheme are the same as they used to be. However in the second part, we can see that now Font Awesome icons are correctly used when FontAwesome is set as the iconTheme.
Executed Tests
No test executed exept manual tests similar to the one in the demo.
Expected merging strategy