Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-17111: User profile sections are using <h1> tag for sub-heading #1668

Closed
wants to merge 1 commit into from

Conversation

slauriere
Copy link
Contributor

  • Update profile sections to use h2 level headings instead of h1 and h3 instead of h2

* Update profile sections to use h2 level headings instead of h1 and h3
  instead of h2
@surli
Copy link
Member

surli commented Aug 30, 2021

@slauriere could you provide a screenshot before/after your changes to see the difference? Also my only worry here is that I'm wondering if we could have some JS that relies on those h2 tags? Maybe @mflorea would have an idea?

@vmassol
Copy link
Member

vmassol commented Aug 30, 2021

AFAIK this is not related to the user profile and we've used H1 voluntarily. It's even excluded from the WCAG tests. We could decide to change this but it needs a proper discussion IMO.

See https://dev.xwiki.org/xwiki/bin/view/Community/WCAGTesting#HTestExceptions

@surli
Copy link
Member

surli commented Dec 17, 2021

We could decide to change this but it needs a proper discussion IMO.

That's apparently also the opinion of Marius and Anca on the ticket comments: https://jira.xwiki.org/browse/XWIKI-17111. Sounds like it will take a bit more time to be fixed, maybe change the status of this PR to draf @slauriere ?

@slauriere slauriere marked this pull request as draft December 17, 2021 10:34
@slauriere
Copy link
Contributor Author

Indeed @surli I converted it to draft, thank you for your input

@Sereza7
Copy link
Contributor

Sereza7 commented Jan 23, 2024

Closing this PR as its issue was solved along XWIKI-21370 <--jira
PR to fix --> XWIKI-21370: Header structure uses too many H1

@Sereza7 Sereza7 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants