Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodi 18 crash fix #1

Merged
merged 5 commits into from
Mar 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# plugin.program.autocompletion
Plugin to provide autocompletion for the virtual keyboard (needs skin support)

Will be working only with https://github.com/xulek/script.module.autocompletion

The autocompletion is limited to a global/kodi builtin search. With plugins cause Kodi19 application to crash. This is a 99% KODI bug.

Resolved crash under Kodi 18.x due to multiple busy dialogs. Tested with youtube and vimeo plugins on Rpi4 (Retropie / Kodi 18.7)
2 changes: 1 addition & 1 deletion addon.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="plugin.program.autocompletion" name="AutoCompletion for virtual keyboard" version="1.0.1" provider-name="Philipp Temminghoff (phil65)">
<addon id="plugin.program.autocompletion" name="AutoCompletion for virtual keyboard" version="1.0.2" provider-name="Philipp Temminghoff (phil65)">
<requires>
<import addon="xbmc.python" version="2.25.0"/>
<import addon="script.module.autocompletion" version="1.0.0"/>
Expand Down
2 changes: 1 addition & 1 deletion plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def pass_list_to_skin(data=[], handle=None, limit=False):
if data:
items = create_listitems(data)
xbmcplugin.addDirectoryItems(handle=handle, items=[(i.getProperty("path"), i, False) for i in items], totalItems=len(items))

xbmc.executebuiltin('Dialog.Close(busydialog)') # Fix Kodi 18.x
xbmcplugin.endOfDirectory(handle)


Expand Down