Determinant example documentation fix #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The determinant of the example is supposed to be zero, which is the output of `xt::linalg::det(a)`. And for zero determinant matrices, the sign is 0 and logdet is -inf.
|
Thanks! How about using a different example that gives nicer results? |
|
I agree @wolfv we should use something that is well-determined. The current examples may give unneeded confusion... |
|
See #191 . The current example is terrible, because it involves taking |
tdegeus
reviewed
Apr 5, 2021
Improving output clarity, according @tdegeus suggestion Co-authored-by: Tom de Geus <[email protected]>
Improving output clarity, according @tdegeus suggestion Co-authored-by: Tom de Geus <[email protected]>
tdegeus
approved these changes
Apr 5, 2021
|
@tatatupi thanx! The issues on the CI are due to the removal of gcc-7 and gcc-8 from the defualt install. I will fix them in a dedicated PR. |
JohanMabille
reviewed
Apr 6, 2021
| auto d = xt::linalg::det(a); | ||
| std::cout << d << std::endl; // 6.661338e-16 | ||
| std::cout << d << std::endl; // 42.0 |
There was a problem hiding this comment.
Perfect! But what is the question? ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The determinant of the example is supposed to be zero, which is the output of
xt::linalg::det(a). And for zero determinant matrices, the sign is 0 and logdet is -inf.