Don't deprecate transpose=FALSE

xrobin · Jul 7, 2024 · ee29346 · ee29346
1 parent f7b8bfd
commit ee29346
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/R/coords.R b/R/coords.R
@@ -44,15 +44,15 @@ coords.smooth.roc <- function(smooth.roc,
   	warning("'drop' is deprecated and will be removed in a future version.")
   }
 
-  if (as.matrix) {
+  if (!missing(as.matrix)) {
   	warning("'as.matrix' is deprecated and will be removed in a future version.")
   }
 
   if (transpose) {
-	warning("'transpose' is deprecated and will be removed in a future version.")
+	warning("'transpose=TRUE' is deprecated. Only 'transpose=FALSE' will be allowed in a future version.")
   }
 
-  if (as.list) {
+  if (!missing(as.list)) {
   	warning("'as.list' is deprecated and will be removed in a future version.")
   }
 
@@ -200,15 +200,15 @@ coords.roc <- function(roc,
 	warning("'drop' is deprecated and will be removed in a future version.")
   }
 
-  if (as.matrix) {
+  if (!missing(as.matrix)) {
 	warning("'as.matrix' is deprecated and will be removed in a future version.")
   }
 
   if (transpose) {
-	warning("'transpose' is deprecated and will be removed in a future version.")
+  	warning("'transpose=TRUE' is deprecated. Only 'transpose=FALSE' will be allowed in a future version.")
   }
 
-  if (as.list) {
+  if (!missing(as.list)) {
 	warning("'as.list' is deprecated and will be removed in a future version.")
   }
 

diff --git a/man/coords_transpose.Rd b/man/coords_transpose.Rd
@@ -75,17 +75,21 @@ THIS CHANGE IS BACKWARDS INCOMPATIBLE AND IS EXPECTED TO BREAK LEGACY CODE.
 }
 
 \section{Changes in 1.19}{
-\itemize{
-	\item{Deprecated \code{transpose}, \code{as.list}, \code{as.matrix} and \code{drop}.}
+\enumerate{
+	\item{Setting \code{transpose=TRUE} is deprecated and triggers a warning.}
+	\item{The  \code{as.list}, \code{as.matrix} and \code{drop} are deprecated.
+	Setting them to any value triggers a waring.}
+	\item{\code{transpose=FALSE} continues to work normally.}
 }
 }
 
 \section{Changes in future versions}{
-\itemize{
-	\item{
-	The \code{transpose} and \code{drop}, \code{as.list} and \code{as.matrix} 
-	arguments will be removed in a future version.
-	}
+\enumerate{
+	\item{Setting \code{transpose} to \code{TRUE} will stop working and result
+	in an error.}
+	\item{The \code{drop}, \code{as.list} and \code{as.matrix} arguments will 
+	be removed.}
+	\item{\code{transpose=FALSE} will keep working indefinitely.}
 }
 }