Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla-ish Tatar Translation! #8

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

Amirhan-Taipovjan-Greatest-I
Copy link
Contributor

Hello!
I need to know what object replaces "%s" in all "betterconfig.commands.config.*"?
It is very important for translating in My case.

Is that a configs or something else?

Hello!
I need to know what object replaces "%s" in all "betterconfig.commands.config.*"?
It is very important for translating in My case.
@xpple xpple added translation For translations enhancement New feature or request labels Aug 6, 2023
@xpple
Copy link
Owner

xpple commented Aug 13, 2023

Thanks for the translations! They are the config’s name and the config’s value. If you can, please test the translations in-game to see if they make sense. Oh and could you remove the ModMenu related translation for now? I haven’t added compatibility for it.

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Amirhan-Taipovjan-Greatest-I commented Aug 14, 2023

They are the config’s name and the config’s value. If you can, please test the translations in-game to see if they make sense.

Sorry, but I don't understand how to test them in-game...
So it would be great, if You tell Me what appears first:
Config's name or value.

Oh and could you remove the ModMenu related translation for now? I haven’t added compatibility for it.

And about ModMenu Integration (or compatibility):
I do not understand, what are y'all mean by that... if this string is working correctly...

@xpple
Copy link
Owner

xpple commented Aug 19, 2023

So it would be great, if You tell Me what appears first:
Config's name or value.

It depends on the config. These are the translations in English with %s replaced, where

  • <name> refers to the config's name,
  • <value> refers to the config's value.

In the case of a map

  • <value> refers to the value of an entry in the map,
  • <key> refers to the key of an entry in the map.
{
  "betterconfig.commands.config.comment": "Comment for <name>:",
  "betterconfig.commands.config.get": "<name> is currently set to <value>.",
  "betterconfig.commands.config.reset": "<name> has been reset to <value>.",
  "betterconfig.commands.config.set": "<name> has been set to <value>.",
  "betterconfig.commands.config.add": "<value> has been added to <name>.",
  "betterconfig.commands.config.put": "The mapping <key>=<value> has been added to <name>.",
  "betterconfig.commands.config.remove": "<value> has been removed from <name>."
}

Hope this helps!

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

So it would be great, if You tell Me what appears first:
Config's name or value.

It depends on the config. These are the translations in English with %s replaced, where

  • <name> refers to the config's name,
  • <value> refers to the config's value.

In the case of a map

  • <value> refers to the value of an entry in the map,
  • <key> refers to the key of an entry in the map.
  "betterconfig.commands.config.comment": "Comment for <name>:",
  "betterconfig.commands.config.get": "<name> is currently set to <value>.",
  "betterconfig.commands.config.reset": "<name> has been reset to <value>.",
  "betterconfig.commands.config.set": "<name> has been set to <value>.",
  "betterconfig.commands.config.add": "<value> has been added to <name>.",
  "betterconfig.commands.config.put": "The mapping <key>=<value> has been added to <name>.",
  "betterconfig.commands.config.remove": "<value> has been removed from <name>."

Hope this helps!

Translation is ready to be merged!

@Amirhan-Taipovjan-Greatest-I Amirhan-Taipovjan-Greatest-I changed the title Vanilla-ish Tatar Translation! (almost done; I have some questions) Vanilla-ish Tatar Translation! Aug 19, 2023
@xpple
Copy link
Owner

xpple commented Aug 19, 2023

Could you remove the surrounding « and »?

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Amirhan-Taipovjan-Greatest-I commented Aug 31, 2023

Could you remove the surrounding « and »?

Hello again! Sorry for long silence from Me...
...And for this question:
Is that necessary?

@xpple
Copy link
Owner

xpple commented Sep 3, 2023

No worries! Well, it makes it consistent with the other translations.

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Amirhan-Taipovjan-Greatest-I commented Sep 3, 2023

I think that in My case it's better to leave these guille­mets (angle quotation marks).

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Bump!

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Bumping again!

@xpple
Copy link
Owner

xpple commented Aug 20, 2024

I disagree still, I prefer the translations to be consistent.

It is for consistency with en_us.json.
@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Amirhan-Taipovjan-Greatest-I commented Aug 20, 2024

I disagree still, I prefer the translations to be consistent.

Ok, that's not a big deal.

@xpple
Copy link
Owner

xpple commented Aug 20, 2024

I think the word чагыштыруы may be wrong here. The word mapping in the English translations means something like "correspondence" or "pairing". It is not an equation (what I think чагыштыруы means) in the sense of a mathematical equality.

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Amirhan-Taipovjan-Greatest-I commented Aug 20, 2024

I think the word чагыштыруы may be wrong here. The word mapping in the English translations means something like "correspondence" or "pairing". It is not an equation (what I think чагыштыруы means) in the sense of a mathematical equality.

Good, I'm going to research that more properly. Thank You.
Yep, that's not easy because there's no actual unified translation for that. Sorry for disturbing You.

@Amirhan-Taipovjan-Greatest-I
Copy link
Contributor Author

Amirhan-Taipovjan-Greatest-I commented Aug 27, 2024

Yep, after some discussion with other Translator who was translating Minecraft too... We've decided to borrow "Mapping".

I think My PR now is ready to be merged, if there's no any other questionable translations.

@xpple
Copy link
Owner

xpple commented Aug 27, 2024

Looks good now, thank you for the translations!

@xpple xpple merged commit a88c7da into xpple:master Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request translation For translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants