Create terraform-apply-actions #16
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,60 @@ | ||
| name: Deploy Xplorers API to GCP | ||
| on: | ||
| push: | ||
| pull_request: | ||
| types: | ||
| - ready_for_review | ||
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| pull-requests: write | ||
| jobs: | ||
| deploy-xplorers-api: | ||
| name: Deploy Xplorers API to GCP | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| shell: bash | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - id: auth | ||
| uses: google-github-actions/[email protected] | ||
| with: | ||
| workload_identity_provider: ${{ secrets.GOOGLE_CLOUD_WORKLOAD_IDENTITY_PROVIDER }} | ||
| - name: Setup Terraform | ||
| uses: hashicorp/setup-terraform@v1 | ||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 9 | ||
| - name: Install taskfile | ||
| run: | | ||
| sudo snap install task --classic | ||
| - name: Terraform Plan | ||
| if: github.event_name == 'pull_request' | ||
| id: plan | ||
| run: task terraform-plan | ||
| - name: Update Pull Request | ||
| uses: actions/github-script@v6 | ||
| if: github.event_name == 'pull_request' | ||
| env: | ||
| PLAN: "terraform\n${{ steps.plan.outputs.stdout }}" | ||
| with: | ||
| result-encoding: string | ||
| script: | | ||
| const output = `#### TASK Terraform Plan 📖\`${{ steps.plan.outcome }}\` | ||
| <details><summary>Show Plan</summary> | ||
| \n | ||
| \`\`\`\n | ||
| ${process.env.PLAN} | ||
| \`\`\` | ||
| \n | ||
| </details> | ||
| *Pushed by: @${{ github.actor }}, Action: \`${{ github.event_name }}\`*`; | ||
| github.rest.issues.createComment({ | ||
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: output | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| name: Terraform Workflow | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
| inputs: | ||
| action: | ||
| description: 'Terraform action to perform' | ||
| required: true | ||
| default: 'plan' | ||
| type: choice | ||
| options: | ||
| - plan | ||
| - apply | ||
|
|
||
| jobs: | ||
| terraform: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - id: auth | ||
| uses: google-github-actions/[email protected] | ||
| with: | ||
| workload_identity_provider: ${{ secrets.GOOGLE_CLOUD_WORKLOAD_IDENTITY_PROVIDER }} | ||
| - name: Setup Terraform | ||
| uses: hashicorp/setup-terraform@v1 | ||
|
|
||
| - name: Terraform Init | ||
| run: terraform init | ||
|
There was a problem hiding this comment. 💡 Codebase verification 🛠️ Refactor suggestion Missing backend configuration in Terraform Init
🔗 Analysis chainPin Terraform setup action version and consider adding backend configuration.
- name: Setup Terraform
uses: hashicorp/[email protected] # Or the latest specific version
- name: Terraform Init
run: |
terraform init \
-backend-config="bucket=${{ secrets.TF_STATE_BUCKET }}" \
-backend-config="prefix=terraform/state"Don't forget to add the To ensure the Terraform configuration includes a backend, run: This will help verify that a backend is defined in your Terraform configuration. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if Terraform configuration includes a backend
grep -R 'backend "' .
Length of output: 6531
samurato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - name: Terraform Plan | ||
| if: github.event.inputs.action == 'plan' | ||
| run: task terraform-plan | ||
|
|
||
| - name: Terraform Apply | ||
| if: github.event.inputs.action == 'apply' | ||
| run: task terraform-apply | ||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion Enhance error handling and output capturing for Terraform steps. While the conditional execution of plan and apply steps is correct, consider adding error handling and output capturing to improve the workflow's robustness and observability. Here's an improved version of these steps: - name: Terraform Plan
if: github.event.inputs.action == 'plan'
run: |
task terraform-plan 2>&1 | tee plan_output.txt
if [ ${PIPESTATUS[0]} -ne 0 ]; then
echo "Terraform plan failed"
exit 1
fi
- name: Terraform Apply
if: github.event.inputs.action == 'apply'
run: |
task terraform-apply 2>&1 | tee apply_output.txt
if [ ${PIPESTATUS[0]} -ne 0 ]; then
echo "Terraform apply failed"
exit 1
fi
- name: Upload Terraform Output
if: always()
uses: actions/upload-artifact@v3
with:
name: terraform-output
path: |
plan_output.txt
apply_output.txtThis change adds error checking and uploads the output as artifacts, which can be useful for debugging and auditing. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
Are you able to test this by running this on your branch (removing hardcoded main on L6)? Just to be sure that this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a limitation workflow dispatch works on main branch only regardless of which branch we declared in workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But did my testing here https://github.com/samurato/gh-actions-test