Lots of linting #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [fix] Made `gradlew` executable (`chmod +x`) - [lint] Weakened visibility on all elements of code where possible - [lint] Declared constants as `final` - [lint] Unicode escape sequence '\u26A0' can be replaced with '⚠'; unnecessary unicode escape sequences. The file encoding can handle the character without escaping it. - [lint] Specify type of lambda function parameters - [lint] Renamed constants using THIS_CASE - [lint] Moved region room management (`generateLink`, `find` and `find` methods) to inner class `Listener` - [lint] Exploded multi-expressions on separate lines for readability, debuggability and simplicity - [lint] Extracted `throw` statement from inside a `try` block - [lint] Catch `Exception` rather than `Throwable` (https://cwe.mitre.org/data/definitions/396, https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors) - [lint] Replaced big `if`/`else if`/`if` section with switch statement - [lint] import inner class rather than reference it by its parent class
|
@phinner quel ton avis sur ce PR ? |
|
💀 Oh I did not even noticed it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradlewexecutable (chmod +x)finalgenerateLink,findandfindmethods) to inner classListenerthrowstatement from inside atryblockExceptionrather thanThrowable(https://cwe.mitre.org/data/definitions/396, https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors)if/else if/ifsection with switch statement