Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: added show/hide ID toggle #456

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

Dranni21312
Copy link
Contributor

This adds a toggle to the map that shows or hides object IDs.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Once this branch successfully builds, you will be able to try the branch out for yourself by changing the "branch" in your updater to "map_hide_ids" (without the quotes).
This setting can be found under the "Updates" tab.

Don't forget to change back when you are done testing. You should reset your branch either to 'stable' for normal releases, or 'master' for beta builds.

@Dranni21312
Copy link
Contributor Author

Makes sense, I updated that.

@xpdota
Copy link
Owner

xpdota commented Nov 7, 2023

One other minor improvement, if you move it up to line 686, then it will work immediately rather than waiting for an HP change (since the 'return' might make it leave that method early).

@Dranni21312
Copy link
Contributor Author

Done!

@xpdota
Copy link
Owner

xpdota commented Nov 7, 2023

Thank you!

@xpdota xpdota merged commit ab8e5b0 into xpdota:master Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants