-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock position #57
base: master
Are you sure you want to change the base?
Clock position #57
Conversation
I've just thought. US keyboards have other differences to my UK one. Can you print out the top row here? Never mind. |
ttyclock.c
Outdated
case '^': | ||
case '&': | ||
case '*': | ||
case '(': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do we use shift here? this is bound to fail depending on the keyboard mapping... why not just use the normal digits?
README
Outdated
@@ -18,3 +18,4 @@ usage : tty-clock [-iuvsScbtrahDBxn] [-C [0-7]] [-f format] [-d delay] [-a nsdel | |||
-B Enable blinking colon | |||
-d delay Set the delay between two redraws of the clock. Default 1s. | |||
-a nsdelay Additional delay between two redraws in nanoseconds. Default 0ns. | |||
-p [1-9] Position of clock in terminal: 1-9 starting top-left and ending bottom-right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"starting top-left and ending bottom-right"... how do we get to "bottom left"? :)
i guess we want to say something like "starting clockwise from the top-left" or something like that.
should we make 0 be "center" and remove the other flag? ;)
I used those characters because the numbers are already mapped for colours. I guess it would have some problems for people using keyboards with different number symbols. I'm not sure how to address that unless we use numbers and assign something else for colours? It's not really clockwise though. I guess a diagram in the readme would help more: |
I see. Well, if you need to draw a diagram for users to understand, I
would suggest you change to a "clockwise" positionning scheme, with zero
in the middle. Usability trumps implementation triviality. :p
Regarding the keybindings, I think I would prefer simply not having any
keybindings to messing around with keyboard layouts. I would accept a
compromise by using arrow keys, but that's about it.
let's keep this simple.
|
All I can say is that telephones and keyboards have been using or 789 for years. Clockwise would be much harder to remember than simple rows imho. I can take out the keybinds. |
I don't mind using the phone layout if you can explain it clearly, but
consider that you have already given two contradictory examples of how
those could be laid out, which won't make it easy for people to
understand where it will show up.
|
I think that |
Added -p [1-9] switch for clock position. (I went with 0-9 initially but since the keys are in 1-9 order it seemed more logical).
Added keys for shift + numbers - !"#$%^&*( to set postition on-the-fly.
Added support for GB keyboards using £ instead of # (wchar.h).