Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated SOURCE and HEADER from SRC #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbohmann
Copy link

Prior to this change, a variable SRC was used, including ttyclock.c and ttyclock.h, for both dependencies and the C compiler call.

This led to incompatibilities with stricter C compiler, like clang.

Prior to this change, a variable SRC was used, including ttyclock.c and ttyclock.h, for both dependencies and the C compiler call.

This led to incompatibilities with stricter C compiler, like clang.
@sbohmann
Copy link
Author

Here's the separate pull request for the Makefile and I must admit that was a good catch on your side, as simply removing the header file from SRC would have led to a missing dependency for building the binary 🙂

I hope you will find this pull request more thoughtful with regard to its implications on the Makefile.

Copy link
Collaborator

@anarcat anarcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants