Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: support pygloo on Windows #51

Merged
merged 47 commits into from
Jul 28, 2023
Merged

Conversation

YibinLiu666
Copy link
Contributor

@YibinLiu666 YibinLiu666 commented Jul 20, 2023

What do these changes do?

Related issue number

Fixes #33

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.0.9 milestone Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #51 (75287e3) into main (c329d28) will increase coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   93.00%   93.60%   +0.59%     
==========================================
  Files          42       42              
  Lines        3361     3361              
  Branches      376      672     +296     
==========================================
+ Hits         3126     3146      +20     
+ Misses        155      144      -11     
+ Partials       80       71       -9     
Flag Coverage Δ
unittests 93.45% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

CMakeLists.txt Outdated Show resolved Hide resolved
cpp/collective/rendezvous/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/collective/rendezvous/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/collective/rendezvous/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/collective/rendezvous/include/utils.hpp Outdated Show resolved Hide resolved
python/setup.py Show resolved Hide resolved
python/xoscar/collective/tests/test_pygloo_tcp_store.py Outdated Show resolved Hide resolved
python/xoscar/collective/tests/test_pygloo.py Show resolved Hide resolved
Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit c3ac228 into xorbitsai:main Jul 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: collective communication supports windows
4 participants