Revert "BUG: disable import cuda error when cpu only in a shared python env" #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 93.75% 93.60% -0.15%
==========================================
Files 42 42
Lines 3361 3361
Branches 672 672
==========================================
- Hits 3151 3146 -5
- Misses 138 144 +6
+ Partials 72 71 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #47
Here' a big issue due to this PR:
When the use's env has some problem (for example, python env has cupy and cudf, while the machine is a cpu machine), this pr will leads to some unexpected problems. Because in this case
cudf is not NoneisTrue, but when user usescudf.xxx, problems would happen.Will fix this in another PR.