Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: URLs link to original lightgbm and xgboost docs #822

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

Dawnfz-Lenfeng
Copy link
Contributor

What do these changes do?

  • add a comparison table for the APIs of LightGBM and XGBoost.
  • The table provides a side-by-side reference of commonly used methods for both libraries, including links to their respective documentation pages.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the documentation Improvements or additions to documentation label Oct 9, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (1ec2519) to head (02c3398).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   82.96%   82.96%           
=======================================
  Files        1071     1071           
  Lines       80083    80083           
  Branches    16545    16545           
=======================================
+ Hits        66441    66443    +2     
+ Misses      12036    12029    -7     
- Partials     1606     1611    +5     
Flag Coverage Δ
unittests 82.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title DOC: add lightgbm and xgboost DOC: update lightgbm and xgboost Oct 9, 2024
@luweizheng luweizheng changed the title DOC: update lightgbm and xgboost DOC: URLs link to original lightgbm and xgboost docs Oct 9, 2024
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 5b471fb into xorbitsai:main Oct 9, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants