Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support cudf Buffer BufferOwner structure #798

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

hucorz
Copy link
Collaborator

@hucorz hucorz commented Aug 18, 2024

What do these changes do?

cudf update its Buffer memory structure. It adds a BufferOwner structure.
See https://github.com/rapidsai/cudf/blob/branch-24.08/python/cudf/cudf/core/buffer/buffer.py
This PR make Xorbits compatible with the latest cudf memory structure.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added bug Something isn't working gpu labels Aug 18, 2024
@XprobeBot XprobeBot added this to the v0.7.3 milestone Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (bf9317e) to head (384ba23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   80.70%   80.72%   +0.01%     
==========================================
  Files        1070     1070              
  Lines       80019    80019              
  Branches    16525    16525              
==========================================
+ Hits        64583    64595      +12     
+ Misses      13875    13862      -13     
- Partials     1561     1562       +1     
Flag Coverage Δ
unittests 80.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title fix: cudf Buffer memory structure ENH: cudf Buffer memory structure Aug 18, 2024
@XprobeBot XprobeBot added enhancement New feature or request and removed bug Something isn't working labels Aug 18, 2024
@luweizheng luweizheng changed the title ENH: cudf Buffer memory structure ENH: support cudf Buffer BufferOwner structure Aug 18, 2024
@luweizheng luweizheng self-requested a review August 18, 2024 14:46
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit c4e4931 into xorbitsai:main Aug 18, 2024
29 of 36 checks passed
@hucorz hucorz deleted the Fix-cudf-memory-structure branch August 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants