Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: df.agg with kwargs #707

Merged
merged 3 commits into from
Sep 19, 2023
Merged

BUG: df.agg with kwargs #707

merged 3 commits into from
Sep 19, 2023

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #703

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Sep 19, 2023
@XprobeBot XprobeBot added this to the v0.6.2 milestone Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #707 (7986879) into main (bb4c746) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   93.50%   93.53%   +0.02%     
==========================================
  Files        1025     1025              
  Lines       79353    79353              
  Branches    16440    16440              
==========================================
+ Hits        74201    74220      +19     
+ Misses       3467     3444      -23     
- Partials     1685     1689       +4     
Flag Coverage Δ
unittests 93.42% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/xorbits/_mars/dataframe/reduction/aggregation.py 94.17% <100.00%> (+0.64%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit f16df9d into xorbitsai:main Sep 19, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.agg with kwargs failed
3 participants