Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove redundant arg _key #636

Closed
wants to merge 28 commits into from
Closed

Conversation

Flying-Tom
Copy link
Contributor

@Flying-Tom Flying-Tom commented Jul 31, 2023

What do these changes do?

Remove redundant arg _key in _mars.core.base

Related issue number

Fixes #443

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Jul 31, 2023
@XprobeBot XprobeBot added this to the v0.5.1 milestone Jul 31, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #636 (125f7fe) into main (bc0c60c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   82.50%   82.54%   +0.03%     
==========================================
  Files        1025     1025              
  Lines       79377    79377              
  Branches    16443    16443              
==========================================
+ Hits        65491    65522      +31     
+ Misses      11627    11589      -38     
- Partials     2259     2266       +7     
Flag Coverage Δ
unittests 82.41% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xorbits/_mars/core/base.py 99.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@aresnow1
Copy link
Contributor

aresnow1 commented Aug 2, 2023

Add a test to check the copied one is same as original.

@XprobeBot XprobeBot modified the milestones: v0.5.1, v0.5.2 Aug 14, 2023
@XprobeBot XprobeBot modified the milestones: v0.5.2, Temp Sep 8, 2023
@XprobeBot XprobeBot modified the milestones: v0.6.0, v0.6.1 Sep 8, 2023
@XprobeBot XprobeBot modified the milestones: v0.6.1, v0.6.2, v0.6.3 Sep 15, 2023
@Flying-Tom
Copy link
Contributor Author

A fix has been done in #709 so this one closed

@Flying-Tom Flying-Tom closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: df.copy() Error
3 participants