Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix df deep copy #709

Merged
merged 7 commits into from
Sep 22, 2023
Merged

BUG: fix df deep copy #709

merged 7 commits into from
Sep 22, 2023

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #443
Fixes #700

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Sep 20, 2023
@XprobeBot XprobeBot added this to the v0.6.3 milestone Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #709 (3f86922) into main (384e453) will increase coverage by 0.03%.
The diff coverage is 97.43%.

@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
+ Coverage   93.52%   93.56%   +0.03%     
==========================================
  Files        1025     1025              
  Lines       79373    79405      +32     
  Branches    16443    16453      +10     
==========================================
+ Hits        74232    74293      +61     
+ Misses       3459     3431      -28     
+ Partials     1682     1681       -1     
Flag Coverage Δ
unittests 93.45% <97.43%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xorbits/_mars/core/entity/tileables.py 89.90% <94.73%> (+0.27%) ⬆️
python/xorbits/_mars/core/base.py 99.00% <100.00%> (ø)
python/xorbits/_mars/dataframe/core.py 94.26% <100.00%> (+0.38%) ⬆️
python/xorbits/_mars/deploy/oscar/session.py 95.12% <100.00%> (+0.04%) ⬆️
python/xorbits/core/adapter.py 97.59% <100.00%> (+0.01%) ⬆️

... and 11 files with indirect coverage changes

@Flying-Tom Flying-Tom mentioned this pull request Sep 21, 2023
2 tasks
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ebc391f into xorbitsai:main Sep 22, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.copy() failed BUG: df.copy() Error
3 participants