Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async callback onStopAsync #257

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Add async callback onStopAsync #257

merged 2 commits into from
Jun 21, 2024

Conversation

devsdocs
Copy link
Contributor

Useful if the callback required an async operation, not perfect but just a simple idea.

Useful if the callback required an async operation, not perfect but just a simple idea.
@HeySreelal
Copy link
Member

HeySreelal commented Jun 21, 2024

Hey!! Thanks for the contribution and the idea!

But, I think it's better to make the current _onStop method to accept something like FutureOr<void> Function(), so we don't have to add a separate method to do the same, right? Let me know what you think :)

@devsdocs
Copy link
Contributor Author

Agree! Even better.

@HeySreelal
Copy link
Member

Perfect, I'll wait for the updated PR - if you're on this :)

@HeySreelal HeySreelal changed the base branch from main to dev June 21, 2024 10:39
@HeySreelal HeySreelal merged commit ea777be into xooniverse:dev Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants