Merge pull request #11 from srishaharidas/XOL-3591

XOL-3591 Store balance_transaction in remoteData for Stripe refunds
xola · Aug 1, 2017 · c0c8187 · c0c8187
2 parents 0697e5f + b08971f
commit c0c8187
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/Message/RefundRequest.php b/src/Message/RefundRequest.php
@@ -128,6 +128,17 @@ public function getData()
 
     public function getEndpoint()
     {
-        return $this->endpoint.'/charges/'.$this->getTransactionReference().'/refund';
+        $endPoint = $this->endpoint.'/charges/'.$this->getTransactionReference().'/refund';
+        $expandParams = $this->getExpand();
+        if ($expandParams && is_array($expandParams)) {
+            $endPoint = $endPoint . '?';
+            foreach ($expandParams as $idx => $param) {
+                $endPoint .= "expand[]=" . urlencode($param);
+                if ($idx !== count($expandParams) - 1) {
+                    $endPoint .= "&";
+                }
+            }
+        }
+        return $endPoint;
     }
 }
diff --git a/tests/Message/RefundRequestTest.php b/tests/Message/RefundRequestTest.php
@@ -66,4 +66,27 @@ public function testSendError()
         $this->assertNull($response->getCardReference());
         $this->assertSame('Charge ch_12RgN9L7XhO9mI has already been refunded.', $response->getMessage());
     }
+
+    public function testShouldReturnEndpointWhenExpandParamNotPresent()
+    {
+        $endPoint = $this->request->getEndpoint();
+
+        $this->assertEquals("https://api.stripe.com/v1/charges/ch_12RgN9L7XhO9mI/refund", $endPoint);
+    }
+
+    public function testShouldAppendExpandQueryParamsToEndpointIfPresent()
+    {
+        $this->request->initialize(
+            array(
+                'amount' => '10.00',
+                'transactionReference' => "ch_12RgN9L7XhO9mI",
+                'expand' => array('foo', 'bar')
+            )
+        );
+        $expected ="https://api.stripe.com/v1/charges/ch_12RgN9L7XhO9mI/refund?expand[]=foo&expand[]=bar";
+
+        $endPoint = $this->request->getEndpoint();
+
+        $this->assertEquals($expected, $endPoint);
+    }
 }