Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file_format simple name ref only no def #274

Conversation

dmaresma
Copy link
Contributor

fix the issue #273

@xnuinside xnuinside merged commit 2ef4718 into xnuinside:main Aug 1, 2024
8 checks passed
@xnuinside
Copy link
Owner

@dmaresma thanks for contribution. Can I ask question? Why you use simple-ddl-parser and not sqlglot, for example? as I understand sqlglot also supports different dialects. Is it because of output format? I'm thinking about adding sqlglot as engine for parser.

@dmaresma
Copy link
Contributor Author

dmaresma commented Aug 1, 2024

Hi Xnuinside, I code a CICD command line util to compare ddl : between a local git repo and online database schema, the issue is we are using a SQL Code generator as Matillion (Scheduler and ETL) but the SQL code isn't fancy. We use to deploy Snowflake database's changes with Liquibase, but I decide to use a Declarative way, to compare (with simple-ddl-parser) and generate unified and on-demand SQL deployment script to Alter schemas, just as sqlpackage for Microsoft SQL Server. I don't know if sqlglot can translate SQL ddl as simple-ddl-paser do, but for sure, for Compute Column definition (or Virtual Column) it could be a great improvement.

@xnuinside
Copy link
Owner

@dmaresma thanks for explicit answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants