Support Parse MYSQL DDL with 'COLLATE' option & fix class typo #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bomwo thanks for the PR and sorry for the delay! I will create new release today |
xnuinside
approved these changes
Jul 28, 2024
|
@bomwo https://pypi.org/project/simple-ddl-parser/ I just released 1.5.2 version with your changes |
Thank you for your review. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This Pull Request addresses the following two issues:
Fix Issue #265:
Problem Description: This resolves the bug reported in Issue #265.
Solution: Identified the cause of the bug and corrected the relevant code. This ensures the affected functionality works as intended.
Correct Class Name Typo:
Problem Description: A typo was found in a specific class name within the codebase.
Solution: Corrected the typo to improve code readability and maintain consistency.
I hope this contribution helps improve the quality of the project. I would appreciate it if you could review the changes.
Please let me know if there are any further adjustments or feedback needed.
Thank you.