Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sendMessage endpoint #53

Merged
merged 6 commits into from
Feb 9, 2024
Merged

feat: add sendMessage endpoint #53

merged 6 commits into from
Feb 9, 2024

Conversation

37ng
Copy link
Contributor

@37ng 37ng commented Jan 30, 2024

closes #19

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (200068d) 89.07% compared to head (ee02daf) 89.85%.
Report is 2 commits behind head on main.

Files Patch % Lines
xps-gateway/src/lib.rs 0.00% 2 Missing ⚠️
gateway-types/src/error.rs 0.00% 1 Missing ⚠️
messaging/src/lib.rs 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   89.07%   89.85%   +0.78%     
==========================================
  Files          10       12       +2     
  Lines         293      355      +62     
==========================================
+ Hits          261      319      +58     
- Misses         32       36       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@37ng 37ng marked this pull request as draft January 30, 2024 22:23
@37ng
Copy link
Contributor Author

37ng commented Jan 30, 2024

Turned out I was using out of date contract, I'm updating this and use sendMessageSigned

Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start. Let me know once it's ready for a final review and I can start and run it and check it out in more detail.

The send message signed should have a multiple message test to confirm nonce is working properly. In general, a few more tests would be great.

xps-gateway/src/rpc/api.rs Outdated Show resolved Hide resolved
@37ng 37ng marked this pull request as ready for review February 4, 2024 20:39
@37ng
Copy link
Contributor Author

37ng commented Feb 4, 2024

Ready for review

@37ng 37ng force-pushed the 37ng/send_message branch from 82e3a05 to 99ebdcf Compare February 9, 2024 05:24
@insipx
Copy link
Contributor

insipx commented Feb 9, 2024

in light of discussion of #52 can approve

@37ng
Copy link
Contributor Author

37ng commented Feb 9, 2024

in light of discussion of #52 can approve

Just added the SendMessageResult following the current pattern + a failure test.

@37ng 37ng merged commit 470c257 into main Feb 9, 2024
6 checks passed
@37ng 37ng deleted the 37ng/send_message branch February 9, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

JSON RPC sendGroupMessage
3 participants