Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grant_installation #35

Closed

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Jan 17, 2024

What ?

This PR adds support for registering a new installation.

Design considerations

The xps-gateway is the executable endpoint, that manages the rpc endpoint. It will setup an rpc server that would listen for incoming requests and perform input validation. Valid requests would be forwarded to the inbox / messaging / registry crates for method-specific implementation.

Requirements

This PR followed the design details in #22; discussion in #13 and xmtp/libxmtp#274

Note

This PR replaces #31, which has the wrong email in the commit ( i.e. unverified commit ).

@tsachiherman tsachiherman self-assigned this Jan 17, 2024
@tsachiherman tsachiherman linked an issue Jan 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (ce75da2) 78.94% compared to head (40a0e5d) 36.84%.

❗ Current head 40a0e5d differs from pull request most recent head a1f9b25. Consider uploading reports for the commit a1f9b25 to get more accurate results

Files Patch % Lines
xps-gateway/src/rpc/methods.rs 6.52% 43 Missing ⚠️
registry/src/registry.rs 0.00% 16 Missing ⚠️
xps-gateway/src/lib.rs 0.00% 4 Missing ⚠️
xps-gateway/src/types.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
- Coverage   78.94%   36.84%   -42.11%     
===========================================
  Files           9       10        +1     
  Lines         114      133       +19     
===========================================
- Hits           90       49       -41     
- Misses         24       84       +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Contact Operations – Registry – RevokeInstallation
1 participant