Copy over server scaffolding #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Jul 28, 2024
| @@ -1,3 +1,64 @@ | |||
| module github.com/xmtp/xmtpd | |||
|
|
|||
| go 1.21.11 | |||
There was a problem hiding this comment.
We should switch to go 1.22, since we are starting fresh and that's the current stable version
neekolas
reviewed
Jul 28, 2024
| @@ -0,0 +1,116 @@ | |||
| package main | |||
There was a problem hiding this comment.
It's convention in Go packages to put these in a cmd folder. Think we should keep that convention
|
Oof. I missed that this PR exists and made an almost identical version. Think the only real difference is that I left out the DB stuff, since I'd like to take a fresh look at the DB migrations since we don't need Bun anywhere in this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically moves over the work from xmtp/xmtp-node-go#397, as well as some utils from the old repo and a clean go dependency list.
NodeRegistryStill need to copy over the CI and docker