Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting options via ENV #128

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Allow setting options via ENV #128

merged 3 commits into from
Aug 30, 2024

Conversation

mkysel
Copy link
Collaborator

@mkysel mkysel commented Aug 30, 2024

Add the option to set any option via the ENV.

Prefix all variables with XMTPD as best practices dictate.

Remove manual env parsing.

@mkysel mkysel requested a review from neekolas August 30, 2024 01:45
@mkysel
Copy link
Collaborator Author

mkysel commented Aug 30, 2024

I will undo the mockery changes...

neekolas
neekolas approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Much tidier this way

@neekolas
Copy link
Contributor

I will undo the mockery changes...

If you run dev/update-tools it should put you on the same version of mockery as the go.mod. You may have to brew uninstall as well, depending on the order of your PATH

@mkysel
Copy link
Collaborator Author

mkysel commented Aug 30, 2024

I will undo the mockery changes...

If you run dev/update-tools it should put you on the same version of mockery as the go.mod. You may have to brew uninstall as well, depending on the order of your PATH

Thanks!

@mkysel mkysel merged commit e7fe0ab into main Aug 30, 2024
4 checks passed
@mkysel mkysel deleted the mkysel/env-variables branch August 30, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkysel @neekolas