Scaffold smart contract event storage #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
neekolas
changed the title
neekolas
changed the title
neekolas
force-pushed
the
08-10-scaffold_smart_contract_event_storage
branch
2 times, most recently
from
fb310ee to
87eaedc
Compare
This was referenced Aug 10, 2024
Merged
neekolas
changed the base branch from
08-09-add_smart_contracts
to
graphite-base/105
neekolas
force-pushed
the
08-10-scaffold_smart_contract_event_storage
branch
from
87eaedc to
c4246b6
Compare
neekolas
force-pushed
the
graphite-base/105
branch
from
0f92343 to
dfcdc77
Compare
Merged
richardhuaaa
approved these changes
Aug 12, 2024
pkg/indexer/indexer.go
Outdated
Comment on lines
55
to
59
| continue Retry | ||
| } | ||
| } | ||
| logger.Info("Stored log", zap.Uint64("blockNumber", event.BlockNumber)) | ||
| break Retry |
There was a problem hiding this comment.
Are the continue/break labels needed here? It seems like we're only breaking out of one loop
There was a problem hiding this comment.
Not needed. I kinda like them for clarity, but that's definitely more a question of style than anything else.
|
|
||
| type LogStorageError interface { | ||
| error | ||
| ShouldRetry() bool |
There was a problem hiding this comment.
Love that retries are built in from the beginning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
AI Assisted summary
Stop()method fromLogStreamerinterface, add custom logger name toRpcLogStreamer.ListenForContractEventto improve event handling.LogStorer.ContractsOptionsinto the server options for configuration.