Skip to content

Commit

Permalink
chore: pin abigen version (#353)
Browse files Browse the repository at this point in the history
Pin the abigen version, so generated golang code is deterministically
generated.
Different versions could introduce changes, and we should avoid pushing
generated code with different versions.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced version pinning for the `abigen` tool to ensure consistent
installation.
	- Added a version check for `abigen` to verify installation integrity.

- **Bug Fixes**
- Removed the installation command for the `abigen` tool from the
script, streamlining the installation process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
fbac authored Dec 23, 2024
1 parent 38ecd2a commit 39ea138
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
12 changes: 11 additions & 1 deletion dev/up
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,19 @@ if ! which mockery &>/dev/null; then go install github.com/vektra/mockery/v2; fi
if ! which sqlc &> /dev/null; then go install github.com/sqlc-dev/sqlc/cmd/sqlc; fi
if ! which buf &> /dev/null; then go install github.com/bufbuild/buf/cmd/buf; fi
if ! which golines &>/dev/null; then go install github.com/segmentio/golines@latest; fi
if ! which abigen &>/dev/null; then go install github.com/ethereum/go-ethereum/cmd/abigen; fi
if ! which jq &>/dev/null; then brew install jq; fi

# Pin abigen version at can introduce breaking changes between releases, rendering different ABIs.
if ! which abigen &>/dev/null; then
go install github.com/ethereum/go-ethereum/cmd/[email protected]
fi

abigen_version=$(abigen --version | awk '{print $3}')
if [[ ${abigen_version} != "1.14.12-stable" ]]; then
echo "ERROR: abigen version is not 1.14.12. Please install the correct version."
exit 1
fi

dev/docker/up
dev/contracts/deploy-local
dev/register-local-node
Expand Down
1 change: 0 additions & 1 deletion dev/update-tools
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ go mod tidy
go install github.com/vektra/mockery/v2
go install github.com/sqlc-dev/sqlc/cmd/sqlc
go install github.com/segmentio/golines@latest
go install github.com/ethereum/go-ethereum/cmd/abigen
go install github.com/golang-migrate/migrate/v4/cmd/migrate
go install github.com/bufbuild/buf/cmd/buf

0 comments on commit 39ea138

Please sign in to comment.