Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm improvements #14

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Helm improvements #14

merged 1 commit into from
Dec 9, 2024

Conversation

mkysel
Copy link
Collaborator

@mkysel mkysel commented Dec 9, 2024

  • Both services got registered with the LB, which does not work. Use a specific selector to only select the API.
  • Use a different port (by default 80) on the LB.
  • use LB by default which exposes the service to the outside world

Tested in GKE and works as expected.

@mkysel mkysel requested review from neekolas and fbac December 9, 2024 18:27
@mkysel mkysel enabled auto-merge (squash) December 9, 2024 19:33
@mkysel mkysel removed the request for review from neekolas December 9, 2024 19:33
@mkysel mkysel merged commit eddcd65 into main Dec 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbac fbac fbac approved these changes

@neekolas neekolas neekolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkysel @neekolas @fbac