Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dexie, remove DB versioning #284

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Upgrade dexie, remove DB versioning #284

merged 5 commits into from
Jul 22, 2024

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Jul 19, 2024

Summary

With Dexie@v4, DB versions no longer need to be updated when the schema changes.

More info here: https://github.com/dexie/Dexie.js/releases/tag/v4.0.1

This may resolve #215.

Other changes

  • Removed CachedMessageWithId and CachedConversationWithId types
  • Refactored cached conversation and message types

Since these changes remove the dbVersion prop from the XMTPProvider component and some exports, they are breaking and will require a major release.

@rygine rygine requested a review from a team July 19, 2024 20:28
Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: 85802e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xmtp/react-sdk Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rygine rygine requested a review from humanagent as a code owner July 19, 2024 20:38
@rygine rygine force-pushed the rygine/db-update branch from ef23371 to 85802e8 Compare July 22, 2024 17:27
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what Dexie does now when we update the schema if the version flag is gone
Wait. You linked to a resource that explains everything

@rygine rygine merged commit 36fecdf into main Jul 22, 2024
5 checks passed
@rygine rygine deleted the rygine/db-update branch July 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: DexieError after upgrade to latest xmtp sdks
2 participants