Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change consent message #238

Closed
wants to merge 3 commits into from
Closed

Change consent message #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
669047b
copy change
May 21, 2024
e397aa4
add changeset
May 21, 2024
2e21a5b
fix test
May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-rules-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@xmtp/consent-proof-signature": patch
---

update consent message
2 changes: 1 addition & 1 deletion packages/consent-proof-signature/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe("createConsentMessage", () => {
const exampleAddress = "0x1234567890abcdef";
const signatureMessage = createConsentMessage(exampleAddress, timestampMs);
expect(signatureMessage).toEqual(
"XMTP : Grant inbox consent to sender\n\nCurrent Time: Fri, 14 Feb 2020 07:00:00 GMT\nFrom Address: 0x1234567890abcdef\n\nFor more info: https://xmtp.org/signatures/",
"XMTP : Grant inbox consent to sender\n\nCurrent Time: Fri, 14 Feb 2020 07:00:00 GMT\nSender Address: 0x1234567890abcdef\n\nFor more info: https://xmtp.org/signatures/",
);
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/consent-proof-signature/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const createConsentMessage = (
"XMTP : Grant inbox consent to sender\n" +
"\n" +
`Current Time: ${new Date(timestampMs).toUTCString()}\n` +
`From Address: ${peerAddress}\n` +
`Sender Address: ${peerAddress}\n` +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be changed in:
iOS: https://github.com/xmtp/xmtp-ios/blob/main/Sources/XMTPiOS/Messages/Signature.swift#L77
Android: https://github.com/xmtp/xmtp-android/blob/main/library/src/main/java/org/xmtp/android/library/messages/Signature.kt#L56
After those there needs to be a React Native update to include those changes and update the tests to include that change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, bummer -- thanks for the heads-up. IMO that's currently not worth the effort for this change so I'm going to delete this PR.

"\n" +
"For more info: https://xmtp.org/signatures/";

Expand Down