-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed frame action payload generation #168
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"mode": "pre", | ||
"mode": "exit", | ||
"tag": "beta", | ||
"initialVersions": { | ||
"@xmtp/react-app": "0.0.0", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@xmtp/frames-client": minor | ||
--- | ||
|
||
Add support for preparing signed payloads for the Frames API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import { publicKey } from "@xmtp/proto"; | ||
|
||
function publicKeyBytesToSign(pubKey: publicKey.PublicKey): Uint8Array { | ||
return publicKey.PublicKey.encode({ | ||
timestamp: pubKey.timestamp, | ||
secp256k1Uncompressed: pubKey.secp256k1Uncompressed, | ||
}).finish(); | ||
} | ||
|
||
function toSignedPublicKey( | ||
v1Key: publicKey.PublicKey, | ||
signedByWallet: boolean, | ||
): publicKey.SignedPublicKey { | ||
if (!v1Key.signature) { | ||
throw new Error("Missing signature"); | ||
} | ||
|
||
let v1Signature = v1Key.signature; | ||
if (signedByWallet) { | ||
v1Signature = { | ||
walletEcdsaCompact: v1Signature.ecdsaCompact, | ||
ecdsaCompact: undefined, | ||
}; | ||
} | ||
|
||
return { | ||
keyBytes: publicKeyBytesToSign(v1Key), | ||
signature: v1Signature, | ||
}; | ||
} | ||
|
||
export function v1ToV2Bundle( | ||
v1Bundle: publicKey.PublicKeyBundle, | ||
): publicKey.SignedPublicKeyBundle { | ||
if (!v1Bundle.identityKey || !v1Bundle.preKey) { | ||
throw new Error("Invalid bundle"); | ||
} | ||
|
||
return { | ||
identityKey: toSignedPublicKey(v1Bundle.identityKey, true), | ||
preKey: toSignedPublicKey(v1Bundle.preKey, false), | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export async function sha256(data: Uint8Array): Promise<Uint8Array> { | ||
const digest = await crypto.subtle.digest("SHA-256", data); | ||
return new Uint8Array(digest); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,22 @@ | ||
export type FramesResponse = { | ||
export type FramesApiResponse = { | ||
url: string; | ||
extractedTags: { [k: string]: string }; | ||
}; | ||
|
||
export type FramePostUntrustedData = { | ||
walletAddress: string; | ||
url: string; | ||
messageId: string; | ||
timestamp: number; | ||
buttonIndex: number; | ||
conversationIdentifier: string; | ||
}; | ||
|
||
export type FramePostTrustedData = { | ||
messageBytes: string; | ||
}; | ||
|
||
export type FramePostPayload = { | ||
untrustedData: FramePostUntrustedData; | ||
trustedData: FramePostTrustedData; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to avoid actually importing
xmtp-js
, so I just re-implemented some functionality for converting V1 bundles to V2 bundles here.