Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read receipt processing #113

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix read receipt processing #113

merged 2 commits into from
Oct 12, 2023

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Oct 12, 2023

in this PR:

  • refactored the read receipt processor to ignore read receipts older than the current one or if the read receipt was sent by the current client
  • added tests for both cases outlined above

@rygine rygine requested a review from a team October 12, 2023 20:43
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 0a7c925

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xmtp/react-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rygine rygine requested a review from jhaaaa as a code owner October 12, 2023 20:45
@rygine rygine merged commit b57a3d8 into main Oct 12, 2023
4 checks passed
@rygine rygine deleted the rygine/fix-read-receipts branch October 12, 2023 21:59
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daria-github daria-github daria-github approved these changes

@jhaaaa jhaaaa Awaiting requested review from jhaaaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rygine @daria-github