Merge pull request #202 from xmtp/nm/add-text-input-support

xmtp · Feb 23, 2024 · 8f4bbf3 · 8f4bbf3
2 parents d866333 + e9a06d8
commit 8f4bbf3
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 8 deletions.
diff --git a/.changeset/gentle-pumpkins-eat.md b/.changeset/gentle-pumpkins-eat.md
@@ -0,0 +1,5 @@
+---
+"@xmtp/frames-client": patch
+---
+
+Add support for optional inputText
diff --git a/packages/frames-client/package.json b/packages/frames-client/package.json
@@ -64,7 +64,7 @@
   "dependencies": {
     "@noble/hashes": "^1.3.3",
     "@open-frames/proxy-client": "^0.2.0",
-    "@xmtp/proto": "3.41.0-beta.5",
+    "@xmtp/proto": "3.44.0",
     "long": "^5.2.3"
   },
   "devDependencies": {

diff --git a/packages/frames-client/src/client.ts b/packages/frames-client/src/client.ts
@@ -32,13 +32,16 @@ export class FramesClient {
 
   async signFrameAction(inputs: FrameActionInputs): Promise<FramePostPayload> {
     const opaqueConversationIdentifier = buildOpaqueIdentifier(inputs);
-    const { frameUrl, buttonIndex } = inputs;
+    const { frameUrl, buttonIndex, inputText } = inputs;
     const now = Date.now();
+    const timestamp = Long.fromNumber(now);
     const toSign: frames.FrameActionBody = {
       frameUrl,
       buttonIndex,
       opaqueConversationIdentifier,
-      timestamp: Long.fromNumber(now),
+      timestamp,
+      inputText: inputText || "",
+      unixTimestamp: now,
     };
 
     const signedAction = await this.buildSignedFrameAction(toSign);
@@ -49,6 +52,7 @@ export class FramesClient {
         buttonIndex,
         opaqueConversationIdentifier,
         walletAddress: this.xmtpClient.address,
+        inputText,
         url: frameUrl,
         timestamp: now,
         unixTimestamp: now,

diff --git a/packages/frames-client/src/proxy.ts b/packages/frames-client/src/proxy.ts
@@ -29,6 +29,9 @@ export default class OpenFramesProxy {
   }
 
   mediaUrl(url: string): string {
+    if (url?.startsWith("data:")) {
+      return url;
+    }
     return this.inner.mediaUrl(url);
   }
 }
diff --git a/packages/frames-client/src/types.ts b/packages/frames-client/src/types.ts
@@ -39,6 +39,7 @@ type ConversationActionInputs = DmActionInputs | GroupActionInputs;
 export type FrameActionInputs = {
   frameUrl: string;
   buttonIndex: number;
+  inputText?: string;
 } & ConversationActionInputs;
 
 type KeyType = {

diff --git a/yarn.lock b/yarn.lock
@@ -4353,7 +4353,7 @@ __metadata:
     "@open-frames/types": "npm:^0.0.6"
     "@rollup/plugin-terser": "npm:^0.4.4"
     "@rollup/plugin-typescript": "npm:^11.1.6"
-    "@xmtp/proto": "npm:3.41.0-beta.5"
+    "@xmtp/proto": "npm:3.44.0"
     "@xmtp/tsconfig": "workspace:*"
     "@xmtp/xmtp-js": "npm:^11.3.12"
     eslint: "npm:^8.56.0"
@@ -4376,15 +4376,15 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@xmtp/proto@npm:3.41.0-beta.5":
-  version: 3.41.0-beta.5
-  resolution: "@xmtp/proto@npm:3.41.0-beta.5"
+"@xmtp/proto@npm:3.44.0":
+  version: 3.44.0
+  resolution: "@xmtp/proto@npm:3.44.0"
   dependencies:
     long: "npm:^5.2.0"
     protobufjs: "npm:^7.0.0"
     rxjs: "npm:^7.8.0"
     undici: "npm:^5.8.1"
-  checksum: 03e9a5d127c5f2af34d80c0b5406fcb862c04dd203142f1d225b11964f9952e811ab97e313a60d8d47c9048b29a7d2196a0c2e8c21d787425543a9e6a9b04e9f
+  checksum: 7124a7be531a501216621033f731bf4777e6ca62df8219dc46db93b2af7d879d402670e8045c274dc61ddafa298f3664d81a9a803e3fcd7fc89f14747e952b38
   languageName: node
   linkType: hard