-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode groups and conversations sequentially to fix iOS pool errors #462
Conversation
cameronvoell
commented
Aug 5, 2024
•
edited
Loading
edited
|
||
return results | ||
|
||
var results: [String] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went ahead and removed TaskGroup from listAll and listConversations since it could lead to similar issues with too many db connections, and I did not observe any slowdown in the test for loading 2000 conversations.
before the change I saw "LOG Loaded 1995 conversations in 5717ms
" and after I saw actually slightly faster "LOG Loaded 1995 conversations in 5595ms
"
@@ -107,7 +106,6 @@ export enum TestCategory { | |||
all = 'all', | |||
tests = 'tests', | |||
group = 'group', | |||
createdAt = 'createdAt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected to be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, these tests were initially just documenting different behaviors between iOS and Android, but looking at them now, they just pass / fail randomly based off random order that groups are returned. tldr, dont think these tests are useful at the moment, and are just creating extra noise, in my opinion, as the person who wrote them :-P
🎉 This PR is included in version 2.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |