Add a test for members inconsistencies when creating new installations #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
reviewed
Aug 5, 2024
example/src/tests/groupTests.ts
Outdated
Comment on lines
2026
to
2031
| const client1Group = (await client1.conversations.listGroups()).find( | ||
| (g) => g.id === group.id | ||
| ) | ||
| const client2Group = (await client2.conversations.listGroups()).find( | ||
| (g) => g.id === group.id | ||
| ) |
There was a problem hiding this comment.
Total nit but you can actually call just find_group directly in V3 instead of iterating over the list.
cameronvoell
approved these changes
Aug 7, 2024
|
🎉 This PR is included in version 2.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create a group with 2 inboxes, and one of those 2 inboxes creates a new installation, then sending a message on the group make it appear like a 1 person group.
This is probably causing a lot of our "group members inconsistencies"
Test fails on Android & iOS, but sometimes on iOS it also fails with "Pool error timed out" which we know happens on iOS...