Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group consent state #371

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Group consent state #371

merged 6 commits into from
Apr 24, 2024

Conversation

nplasterer
Copy link
Contributor

Adds the consent state to group like we have for dms

Fixes #356

@nplasterer nplasterer self-assigned this Apr 18, 2024
@nplasterer nplasterer changed the base branch from main to beta April 18, 2024 22:26
@nplasterer nplasterer marked this pull request as ready for review April 18, 2024 22:35
@nplasterer nplasterer requested a review from a team as a code owner April 18, 2024 22:35
@@ -225,4 +226,8 @@ export class Group<
throw e
}
}

async consentState(): Promise<'allowed' | 'denied' | 'unknown'> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I am wondering whether this is the final state for the group consentState?

I want to display which members of a group have accepted the group invite or not. AFAIK this can only be done on the client for now?

If this function returned the state of each individual member then it would be easier to do directly from the network.

Is this something that might be implemented in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm not sure I understand the question? Are you looking for a way that every person in the group can see if someone else has approved or denied the group? Inherently the personal private preferences are just that private and personal. So no one else in the group can decrypt if your blocked that person or group only you can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep exactly what I was wondering & that clarifies it.

Pending / joined members will have to just be a client-side feature in that case.

Thanks!

@nplasterer nplasterer merged commit c691501 into beta Apr 24, 2024
4 of 5 checks passed
@nplasterer nplasterer deleted the np/group-polish-consent branch April 24, 2024 04:52
Copy link
Contributor

🎉 This PR is included in version 1.32.5-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 1.33.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: group.topic incorrectly returns same value as group.id
4 participants