-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group consent state #371
Group consent state #371
Conversation
@@ -225,4 +226,8 @@ export class Group< | |||
throw e | |||
} | |||
} | |||
|
|||
async consentState(): Promise<'allowed' | 'denied' | 'unknown'> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I am wondering whether this is the final state for the group consentState
?
I want to display which members of a group have accepted the group invite or not. AFAIK this can only be done on the client for now?
If this function returned the state of each individual member then it would be easier to do directly from the network.
Is this something that might be implemented in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm not sure I understand the question? Are you looking for a way that every person in the group can see if someone else has approved or denied the group? Inherently the personal private preferences are just that private and personal. So no one else in the group can decrypt if your blocked that person or group only you can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly what I was wondering & that clarifies it.
Pending / joined members will have to just be a client-side feature in that case.
Thanks!
… np/group-polish-consent
🎉 This PR is included in version 1.32.5-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.33.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds the consent state to group like we have for dms
Fixes #356