Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who Added Me Feature Implementation #366

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

zombieobject
Copy link
Contributor

Introduction 📟

Added the ability to identify the address of who added a member to a group.

@zombieobject zombieobject force-pushed the em/beta/who-added-me branch from 5b98c66 to 59056e9 Compare April 18, 2024 17:50
@zombieobject zombieobject marked this pull request as ready for review April 18, 2024 18:17
@zombieobject zombieobject requested a review from a team as a code owner April 18, 2024 18:17
@zombieobject zombieobject requested a review from alexrisch April 18, 2024 18:17
ios/XMTPModule.swift Outdated Show resolved Hide resolved
src/lib/Group.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note if you want this to trigger a new beta release of the sdk you would want to add feat: or fix: to a commit so that it is triggered. https://github.com/semantic-release/semantic-release I'm going to be funneling through the delivery status soon so not a huge deal to leave those to release together.

@zombieobject
Copy link
Contributor Author

Just a note if you want this to trigger a new beta release of the sdk you would want to add feat: or fix: to a commit so that it is triggered. https://github.com/semantic-release/semantic-release I'm going to be funneling through the delivery status soon so not a huge deal to leave those to release together.

Thanks for the heads up! I wasn't sure if that was pre or post-merge. The release flow is different between repos, so glad to know the process for this one. Thanks for the review. 🙂

@zombieobject zombieobject merged commit 716c0ac into beta Apr 18, 2024
5 of 6 checks passed
@zombieobject zombieobject deleted the em/beta/who-added-me branch April 18, 2024 21:17
Copy link
Contributor

🎉 This PR is included in version 1.32.5-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 1.33.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants